Re: NO WAIT ... - Mailing list pgsql-patches

From Tom Lane
Subject Re: NO WAIT ...
Date
Msg-id 24637.1077127587@sss.pgh.pa.us
Whole thread Raw
In response to NO WAIT ...  (Hans-Jürgen Schönig <postgres@cybertec.at>)
Responses Re: NO WAIT ...
Re: NO WAIT ...
List pgsql-patches
=?ISO-8859-1?Q?Hans-J=FCrgen_Sch=F6nig?= <postgres@cybertec.at> writes:
> i have attached a patch implementing NO WAIT with the help of a GUC
> variable.

I consider this patch incredibly dangerous, as it affects *every* lock
taken, including system internal lock acquisitions.

I think it might be reasonable to implement a no-wait option on explicit
LOCK TABLE commands, and perhaps we could do it for SELECT FOR UPDATE
as well.  But it should not be done in a way that breaks internal lock
attempts.

Also, I don't care for the idea of a GUC variable affecting this.
See recent discussions about how changing fundamental semantics via
easily-changed GUC values is risky.  If we're going to do it we should
add syntax to the LOCK command so that apps explicitly request it.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Doing psql's lexing with flex
Next
From: Bruce Momjian
Date:
Subject: Re: NO WAIT ...