Re: extern keyword incorrectly used in some function definitions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: extern keyword incorrectly used in some function definitions
Date
Msg-id 24180.1519060142@sss.pgh.pa.us
Whole thread Raw
In response to extern keyword incorrectly used in some function definitions  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: extern keyword incorrectly used in some function definitions
List pgsql-hackers
David Rowley <david.rowley@2ndquadrant.com> writes:
> While poking around partition.c I noticed that one of the functions
> there is *defined* as "extern". Normally we'd only do this in the
> declaration of the function. I don't really see why it's needed in the
> definition.
> Anyway, I removed it. I then thought I'd better look around for any
> others too...
> A patch is attached which removes them all, apart from the snowball
> ones. I didn't touch those.

Agreed.  The snowball stuff is just imported from elsewhere, so we're
not going to try to make it conform to project style.  But the rest
of these look good; pushed.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Mark Wong
Date:
Subject: Re: pgbench - allow to specify scale as a size
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench - allow to specify scale as a size