Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Date
Msg-id 230c42b8-5758-3616-b4fd-df9191f0c273@dunslane.net
Whole thread Raw
In response to Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 3/30/22 21:12, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>>> On Mar 30, 2022, at 8:19 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I think this means that its old Perl version misinterprets
>>> use parent -norequire, qw(PostgreSQL::Test::Cluster);
>>> as a request to include "parent.pm".  Is there a more
>>> backwards-compatible way to spell that?
>> Not that I know of. Googling tells me it was a core module from 5.10.1. I can revert tomorrow if necessary :-(



I must have been half asleep when I posted this.

There are three ways out of this that I can see:

. carry a copy of parent.pm in src/test/perl (It's very small)

. use the older and heavier 'base' module which goes back to 5.004, and
does much the same thing (and a lot more)

. just do directly what parent.pm's import() does, as in the attached,
which I have tested down to version 10.

On the whole I think I prefer the last.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment

pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Add diagnostic output on error in pump_until
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: doc: Fix typo in ANALYZE documentation