Re: [HACKERS] src/test/ssl/t/001_ssltests.pl should not tromp on file permissions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] src/test/ssl/t/001_ssltests.pl should not tromp on file permissions
Date
Msg-id 23037.1494905363@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] src/test/ssl/t/001_ssltests.pl should not tromp on file permissions  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> On Tue, May 16, 2017 at 7:05 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> We could maybe make 001_ssltests.pl save and restore the file's
>> permissions, but I think probably a cleaner answer is to have it
>> make a temporary copy and set the permissions on that.

> Ah, you are talking about ss/client.key here... Using a temporary copy
> makes the most sense to me, as there is no need to think about putting
> back the old permissions on test failure, and the original tree
> remains unmodified all the time.

Pushed with minor adjustments --- I made the test script unlink the temp
file at the end, and tightened the .gitignore patterns a bit.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] src/test/ssl/t/001_ssltests.pl should not tromp on file permissions
Next
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] [POC] hash partitioning