Re: Error logging messages - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Error logging messages
Date
Msg-id 22D11FF2-0F2A-4FA0-81B4-D318581CDF5F@yesql.se
Whole thread Raw
In response to Re: Error logging messages  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
> On 14 Apr 2022, at 16:32, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>
> On 13.04.22 13:51, Daniel Gustafsson wrote:
>> 0002: Capitalizes pg_log_error_detail and conversely starts pg_log_error with a
>> lowercase letter without punctuation.
>
> I'm having some doubts about some of these changes, especially for interactive features in psql, where the messages
areoften use a bit of a different style.  I don't think this kind of thing is an improvement, for example: 
>
> -       pg_log_error("You are currently not connected to a database.");
> +       pg_log_error("you are currently not connected to a database");

That may also be a bit of Stockholm Syndrome since I prefer the latter error
message, but I see your point.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File: "toast_internals.c", Line: 670, PID: 19403)
Next
From: Robert Haas
Date:
Subject: Re: BufferAlloc: don't take two simultaneous locks