Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files
Date
Msg-id 22481.1386088215@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: libpq: change PQconndefaults() to ignore invalid service files  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files  (Bruce Momjian <bruce@momjian.us>)
List pgsql-committers
Tree view 
Bruce Momjian <bruce@momjian.us> writes:
> libpq:  change PQconndefaults() to ignore invalid service files
> Previously missing or invalid service files returned NULL.  Also fix
> pg_upgrade to report "out of memory" for a null return from
> PQconndefaults().

Why does this patch remove the errorMessage argument from
pg_fe_getauthname?  I gauge the amount of thought that went into
that choice by the fact that the comment wasn't updated.

            regards, tom lane

pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: libpq: change PQconndefaults() to ignore invalid service files
Next
From: Bruce Momjian
Date:
Subject: pgsql: Update C comment for pg_fe_getauthname