Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files
Date
Msg-id 20131203163356.GD27105@momjian.us
Whole thread Raw
In response to Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tree view 
On Tue, Dec  3, 2013 at 11:30:15AM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > libpq:  change PQconndefaults() to ignore invalid service files
> > Previously missing or invalid service files returned NULL.  Also fix
> > pg_upgrade to report "out of memory" for a null return from
> > PQconndefaults().
>
> Why does this patch remove the errorMessage argument from
> pg_fe_getauthname?  I gauge the amount of thought that went into
> that choice by the fact that the comment wasn't updated.

Oh, the argument was not used, so I remove it.  C comment updated.
Thanks.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: Update C comment for pg_fe_getauthname
Next
From: Tom Lane
Date:
Subject: Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files