Re: [PATCH] Add crc32(text) & crc32(bytea) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Add crc32(text) & crc32(bytea)
Date
Msg-id 2224670.1723128582@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Add crc32(text) & crc32(bytea)  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: [PATCH] Add crc32(text) & crc32(bytea)
List pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Thu, Aug 08, 2024 at 04:27:20PM +0200, Peter Eisentraut wrote:
>> The correct return type of a CRC operation in general is some kind of exact
>> numerical type.  Just pick the best one that fits the result.  I don't think
>> bytea is appropriate.

> That would leave us either "integer" or "bigint".  "integer" is more
> correct from a size perspective, but will result in negative values because
> it is signed.  "bigint" uses twice as many bytes but won't display any CRC
> values as negative.

bigint seems fine to me; we have used that in other places as a
substitute for uint32, eg block numbers in contrib/pageinspect.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: [PATCH] Add crc32(text) & crc32(bytea)
Next
From: vignesh C
Date:
Subject: Re: Logical Replication of sequences