Re: Logical Replication of sequences - Mailing list pgsql-hackers

From vignesh C
Subject Re: Logical Replication of sequences
Date
Msg-id CALDaNm1QQK_Pgx35LrJGuRxBzzYSO8rm1YGJF4w8hYc3Gm+5NQ@mail.gmail.com
Whole thread Raw
In response to Re: Logical Replication of sequences  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Logical Replication of sequences
Re: Logical Replication of sequences
List pgsql-hackers
On Thu, 8 Aug 2024 at 08:30, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Vignesh, Here are my v20240807-0003 review comments.
>
> 2a.
> The paragraph starts by saying "Sequence data is not replicated.". It
> seems wrong now. Doesn't that need rewording or removing?

Changed it to incremental sequence changes.

> ~
>
> 2b.
> Should the info "If, however, some kind of switchover or failover..."
> be mentioned in the "Logical Replication Failover" section [2],
> instead of here?

I think mentioning this here is appropriate. The other section focuses
more on how logical replication can proceed with a new primary. Once
the logical replication setup is complete, sequences can be refreshed
at any time.

Rest of the comments  are fixed,  the attached v20240808 version patch
has the changes for the same.

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Add crc32(text) & crc32(bytea)
Next
From: vignesh C
Date:
Subject: Re: Logical Replication of sequences