Re: debug log in pg_archivecleanup - Mailing list pgsql-hackers

Fujii Masao <masao.fujii@gmail.com> writes:
> On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki
> <itagaki.takahiro@oss.ntt.co.jp> wrote:
>> This is because pg_archivecleanup puts the line break "\n" in the head of
>> debug message. Why should we do so?

> Yes. What about the attached patch?

Applied along with a bit of further editorialization.

>> Note that we don't need a line break at Line 130
>> because strerror() fills the last %s.
>> �L.130: fprintf(stderr, "\n%s: ERROR failed to remove \"%s\": %s",

> Right.

Huh?  strerror() doesn't include a newline.
        regards, tom lane