On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki
<itagaki.takahiro@oss.ntt.co.jp> wrote:
>
> Fujii Masao <masao.fujii@gmail.com> wrote:
>
>> This is because pg_archivecleanup puts the line break "\n" in the head of
>> debug message. Why should we do so?
>>
>> -----------------------
>> if (debug)
>> fprintf(stderr, "\n%s: removing \"%s\"", progname, WALFilePath);
>> -----------------------
>
> We also need "\n" at line 308.
> L.125: fprintf(stderr, "\n%s: removing \"%s\"", progname, WALFilePath);
> L.308: fprintf(stderr, "%s: keep WAL file %s and later", progname, exclusiveCleanupFileName);
Yes. What about the attached patch?
> Note that we don't need a line break at Line 130
> because strerror() fills the last %s.
> L.130: fprintf(stderr, "\n%s: ERROR failed to remove \"%s\": %s",
Right.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
