Re: [HACKERS] Re: [SQL] Column name's length - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Re: [SQL] Column name's length
Date
Msg-id 21646.928250741@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Re: [SQL] Column name's length  (Bruce Momjian <maillist@candle.pha.pa.us>)
Responses Re: [HACKERS] Re: [SQL] Column name's length
List pgsql-hackers
Bruce Momjian <maillist@candle.pha.pa.us> writes:
>> It'd probably be worthwhile to move NAMEDATALEN to config.h and make the
>> other two symbols be computed off NAMEDATALEN.  Any objections if I
>> sneak that change into 6.5, or is it too close to being a "new feature"?

> Don't they have to be visible to outside apps, so it is in postgres_ext.h?

Good point --- I was thinking that postgres_ext.h includes config.h,
but I see it ain't so.  You're right, those definitions must stay where
they are.

Still, I wonder why OIDNAMELEN isn't just defined as
(NAMEDATALEN+sizeof(Oid)) rather than putting a comment to that effect.
I will check the uses and see if that is a safe change or not.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] LIMITS
Next
From: Thomas Lockhart
Date:
Subject: Re: [HACKERS] Outer joins