Re: [HACKERS] Re: [SQL] Column name's length - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Re: [SQL] Column name's length
Date
Msg-id 199906011445.KAA26265@candle.pha.pa.us
Whole thread Raw
In response to Re: [SQL] Column name's length  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Re: [SQL] Column name's length
Re: [HACKERS] Re: [SQL] Column name's length
List pgsql-hackers
> Zalman Stern <zalman@netcom.com> writes:
> > Here are the two diffs that up the "name size" from 32 characters to 256
> > characters. (Once I get bit, I try to fix things real good so I don't get
> > bit again :-))
> > -----
> > diff  postgresql-6.4.2/src/include/postgres_ext.h postgres-build/src/include/postgres_ext.h
> > 34c34
> > < #define NAMEDATALEN 32
> > ---
> >> #define NAMEDATALEN 256
> > 37c37
> > < #define OIDNAMELEN    36
> > ---
> >> #define OIDNAMELEN    260
> > -----
> > diff postgresql-6.4.2/src/include/storage/buf_internals.h postgres-build/src/include/storage/buf_internals.h
> > 87c87
> > < #define PADDED_SBUFDESC_SIZE  128
> > ---
> >> #define PADDED_SBUFDESC_SIZE  1024
> > -----
> 
> It'd probably be worthwhile to move NAMEDATALEN to config.h and make the
> other two symbols be computed off NAMEDATALEN.  Any objections if I
> sneak that change into 6.5, or is it too close to being a "new feature"?

Don't they have to be visible to outside apps, so it is in postgres_ext.h?

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Release date and docs
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] New IP address datatype