Re: pg_autovacuum integration patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: pg_autovacuum integration patch
Date
Msg-id 21589.1087394471@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_autovacuum integration patch  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: pg_autovacuum integration patch  ("Matthew T. O'Connor" <matthew@zeut.net>)
Re: pg_autovacuum integration patch  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
"Magnus Hagander" <mha@sollentuna.net> writes:
> I also noticed:
> !         elog(ERROR, "pg_autovacuum: GUC variable stats_row_level
> must be enabled.");
> !         elog(ERROR, "       Please fix the problems and try
> again.");

> If you use the ereport() call instead of elog, you can set the second
> one as a HINT. Since it's really the same error, I don't think you want
> multiple errors logged...

Even more to the point, control will never *reach* the second elog().
Matthew clearly needs to spend more time studying the backend error
message reporting mechanism.  There is some documentation here:
http://developer.postgresql.org/docs/postgres/error-message-reporting.html
and the backend code is certainly chock-full of examples.

            regards, tom lane

pgsql-patches by date:

Previous
From: Claudio Natoli
Date:
Subject: pg_ctl service integration for WIN32
Next
From: "Matthew T. O'Connor"
Date:
Subject: Re: pg_autovacuum integration patch