Re: pg_autovacuum integration patch - Mailing list pgsql-patches

From Matthew T. O'Connor
Subject Re: pg_autovacuum integration patch
Date
Msg-id 1087394909.20076.30.camel@zedora2
Whole thread Raw
In response to Re: pg_autovacuum integration patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
On Wed, 2004-06-16 at 10:01, Tom Lane wrote:
> "Magnus Hagander" <mha@sollentuna.net> writes:
> > I also noticed:
> > !         elog(ERROR, "pg_autovacuum: GUC variable stats_row_level
> > must be enabled.");
> > !         elog(ERROR, "       Please fix the problems and try
> > again.");
>
> > If you use the ereport() call instead of elog, you can set the second
> > one as a HINT. Since it's really the same error, I don't think you want
> > multiple errors logged...
>
> Even more to the point, control will never *reach* the second elog().
> Matthew clearly needs to spend more time studying the backend error
> message reporting mechanism.  There is some documentation here:
> http://developer.postgresql.org/docs/postgres/error-message-reporting.html
> and the backend code is certainly chock-full of examples.

No doubt, I'll try to take a look at this soon.  Since the deadline is
coming up, I wanted to find out my shortcoming sooner rather than
later.

Put another way, I thought it was time to stop operating in a "VACUUM"
;-)

Matthew



pgsql-patches by date:

Previous
From: "Matthew T. O'Connor"
Date:
Subject: Re: pg_autovacuum integration patch
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_autovacuum integration patch