Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20 - Mailing list pgsql-hackers

I wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> This is causing a compilation warning on Windows:
> ...so I think your compiler has a point.  I shall complain to upstream.

The IANA folk want to fix it like this:

diff --git a/zic.c b/zic.c
index 8bf5628..a84703a 100644
--- a/zic.c
+++ b/zic.c
@@ -2145,7 +2145,7 @@ writezone(const char *const name, const char *const string, char version,
         }
         if (pass == 1 && !want_bloat()) {
           utcnt = stdcnt = thisleapcnt = 0;
-          thistimecnt = - locut - hicut;
+          thistimecnt = - (locut + hicut);
           thistypecnt = thischarcnt = 1;
           thistimelim = thistimei;
         }

I'm not quite convinced whether that will silence the warning, but
at least it's a bit less unreadable.

            regards, tom lane