Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared
Date
Msg-id 21381.1262025958@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared  (momjian@postgresql.org (Bruce Momjian))
Responses Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared  (Bruce Momjian <bruce@momjian.us>)
List pgsql-committers
momjian@postgresql.org (Bruce Momjian) writes:
> Log Message:
> -----------
> Add PGDLLIMPORT for binary_upgrade global variables so shared object
> libraries can access them.

This change is useless, and contrary to our coding standards elsewhere.
You need PGDLLIMPORT on the externs seen by the loadable module.  We
don't put it on the actual variable definitions.

            regards, tom lane

pgsql-committers by date:

Previous
From: momjian@postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared
Next
From: momjian@postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Remove PGDLLIMPORT used for binary upgrade; must be on the