Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared
Date
Msg-id 200912281849.nBSInGY08632@momjian.us
Whole thread Raw
In response to Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> momjian@postgresql.org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Add PGDLLIMPORT for binary_upgrade global variables so shared object
> > libraries can access them.
>
> This change is useless, and contrary to our coding standards elsewhere.
> You need PGDLLIMPORT on the externs seen by the loadable module.  We
> don't put it on the actual variable definitions.

Thanks, I will make the necessary adjustments.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-committers by date:

Previous
From: momjian@postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Remove PGDLLIMPORT used for binary upgrade; must be on the
Next
From: bmomjian@pgfoundry.org (User Bmomjian)
Date:
Subject: pg-migrator - pg_migrator: Stamp 8.4.9.