Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
Date
Msg-id 20643.1232666867@sss.pgh.pa.us
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.  (Bruce Momjian <bruce@momjian.us>)
Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
mha@postgresql.org (Magnus Hagander) writes:
> Explicitly bind gettext to the correct encoding on Windows.

I have a couple of objections to this patch.  First, what happens if
it fails to find a matching table entry?  (The existing answer is
"nothing", but that doesn't seem right.)  Second and more critical,
it adds still another data structure that has to be maintained when
the list of encodings changes, and it doesn't even live in the same
file as any existing encoding-information table.

What makes more sense to me is to add a table to encnames.c that
provides the gettext name of every encoding that we support.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Lock conflict behavior?
Next
From: Jeff Davis
Date:
Subject: Re: Lock conflict behavior?