Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows. - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
Date
Msg-id 200902071511.n17FB4t23514@momjian.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> mha@postgresql.org (Magnus Hagander) writes:
> > Explicitly bind gettext to the correct encoding on Windows.
> 
> I have a couple of objections to this patch.  First, what happens if
> it fails to find a matching table entry?  (The existing answer is
> "nothing", but that doesn't seem right.)  Second and more critical,
> it adds still another data structure that has to be maintained when
> the list of encodings changes, and it doesn't even live in the same
> file as any existing encoding-information table.
> 
> What makes more sense to me is to add a table to encnames.c that
> provides the gettext name of every encoding that we support.

Would someone please comment on Tom's questions above.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: [COMMITTERS] pgsql: Implement prefetching via posix_fadvise() for bitmap index scans.
Next
From: Bruce Momjian
Date:
Subject: Re: pg_get_viewdef formattiing