Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_restore fails with a custom backup file - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_restore fails with a custom backup file
Date
Msg-id 20604.1171736902@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_restore fails with a custom backup file  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pg_restore fails with a custom backup file  (Magnus Hagander <magnus@hagander.net>)
Re: pg_restore fails with a custom backup file  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tree view 
Magnus Hagander <magnus@hagander.net> writes:
> I'd also like a comment from at least one other "patch reviewer" that
> the methods used are good.

It looks reasonable as far as it goes.  One thought is that pg_dump
really should have noticed that it was writing a broken archive.
On machines where off_t is 32 bits, can't we detect the overflow
situation?
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: [GENERAL] [ANNOUNCE] Advisory on possibly insecure security definer functions
Next
From: Warren Turkal
Date:
Subject: Re: RFC: Temporal Extensions for PostgreSQL