Re: pg_restore fails with a custom backup file - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: pg_restore fails with a custom backup file
Date
Msg-id 20070219150712.GB29763@svr2.hagander.net
Whole thread Raw
In response to Re: pg_restore fails with a custom backup file  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Feb 17, 2007 at 01:28:22PM -0500, Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
> > I'd also like a comment from at least one other "patch reviewer" that
> > the methods used are good.
> 
> It looks reasonable as far as it goes.  One thought is that pg_dump
> really should have noticed that it was writing a broken archive.
> On machines where off_t is 32 bits, can't we detect the overflow
> situation?

Tested on MSVC as well, works. Also tested and doesn't break the build
on Linux (which shouldn't be affected at all).

So, patch applied to HEAD and 8.2.

//Magnus


pgsql-hackers by date:

Previous
From: Oleg Bartunov
Date:
Subject: Re: n-gram search function
Next
From: Tom Lane
Date:
Subject: Re: RFC: Temporal Extensions for PostgreSQL