Re: Replace remaining castNode(…, lfirst(…)) and friends calls with l*_node() - Mailing list pgsql-hackers

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2021-Jul-07, Dagfinn Ilmari Mannsåker wrote:
>> PartitionRangeDatum *datum =
>> -        castNode(PartitionRangeDatum, lfirst(cell));
>> +        lfirst_node(PartitionRangeDatum, cell);

> This is pretty personal and subjective, but stylistically I dislike
> initializations that indent to the same level as the variable
> declarations they follow; they still require a second line of code and
> don't look good when in between other declarations.

Yeah, this seems like a pgindent bug to me, but I've not mustered the
energy to try to fix it.  As you say, it can be worked around by not
trying to lay out the code that way.

            regards, tom lane