Re: BUG #18866: Running pg_freespace() on views triggers an Abort - Mailing list pgsql-bugs

From Álvaro Herrera
Subject Re: BUG #18866: Running pg_freespace() on views triggers an Abort
Date
Msg-id 202503261733.mcrnkm6myu6y@alvherre.pgsql
Whole thread Raw
In response to Re: BUG #18866: Running pg_freespace() on views triggers an Abort  ("Euler Taveira" <euler@eulerto.com>)
Responses Re: BUG #18866: Running pg_freespace() on views triggers an Abort
List pgsql-bugs
On 2025-Mar-25, Euler Taveira wrote:

> On Tue, Mar 25, 2025, at 10:18 PM, Tender Wang wrote:
> > Thanks for the advice. Please see the attached patch.
> 
> Your patch needs some adjustments. There is no need to include pg_class.h.

I think including pg_class.h (which is where RELKIND_HAS_STORAGE() is
defined and where errdetail_relkind_not_supported is declared) is better
than including utils/rel.h, which brings in a whole bunch of additional
stuff in addition to pg_class.h :-)

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end." (2nd Commandment for C programmers)



pgsql-bugs by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort
Next
From: "Euler Taveira"
Date:
Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort