Re: BUG #18866: Running pg_freespace() on views triggers an Abort - Mailing list pgsql-bugs

From Euler Taveira
Subject Re: BUG #18866: Running pg_freespace() on views triggers an Abort
Date
Msg-id 3ce0c391-2abc-444d-9a49-5ed86dd6b504@app.fastmail.com
Whole thread Raw
In response to Re: BUG #18866: Running pg_freespace() on views triggers an Abort  (Álvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: BUG #18866: Running pg_freespace() on views triggers an Abort
List pgsql-bugs
On Wed, Mar 26, 2025, at 2:33 PM, Álvaro Herrera wrote:
On 2025-Mar-25, Euler Taveira wrote:

> On Tue, Mar 25, 2025, at 10:18 PM, Tender Wang wrote:
> > Thanks for the advice. Please see the attached patch.

> Your patch needs some adjustments. There is no need to include pg_class.h.

I think including pg_class.h (which is where RELKIND_HAS_STORAGE() is
defined and where errdetail_relkind_not_supported is declared) is better
than including utils/rel.h, which brings in a whole bunch of additional
stuff in addition to pg_class.h :-)

It doesn't work because of RelationGetRelationName() that is defined into
utils/rel.h.


--
Euler Taveira

pgsql-bugs by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort
Next
From: Alvaro Herrera
Date:
Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort