On Thu, 05 Dec 2024 10:39:22 +0900
Masahiro Ikeda <ikedamsh@oss.nttdata.com> wrote:
> On 2024-12-04 21:08, Yugo Nagata wrote:
> > This would prevent other users from make a misunderstanding as you did.
> >
> > I found the description on amvalidate also explains a message is
> > output at INFO level.
> > ( https://www.postgresql.org/docs/devel/index-functions.html )
> >
> > Problems should be reported with ereport messages, typically at INFO
> > level.
> >
> > I don't know the actual intention to mention the message level here,
> > but
> > this might have the same purpose of you.
>
> Thanks for your response!
>
> > Should we add the description for CLUSTER command, since
> > it also has the VERBOSE options?
>
> Yes, you're right. I missed it.
>
> > - Enables display of progress messages.
> > + Prints a detailed analyze activity report for each table as
> > + <literal>INFO</literal> messages.
> >
> > Do we need rewrite the description in addition to mentioning the
> > message level?
>
> Since the messages for the VERBOSE options look similar, I unified the
> descriptions
> for VACUUM, ANALYZE, and REINDEX. However, I don’t have a strong opinion
> on this.
> I’ve fixed it in the v2 patch.
- Prints a progress report as each table is clustered.
+ Prints a progress report as each table is clustered,
+ at <literal>INFO</literal> level.
I feel like the comma could not be necessary here like the fix for
the ANALYZE document, but it might be better to wait for a review
from a native English speaker.
Regards,
Yugo Nagata
--
Yugo NAGATA <nagata@sraoss.co.jp>
