Re: Confine vacuum skip logic to lazy_scan_skip - Mailing list pgsql-hackers

On Mon, Jul 15, 2024 at 03:26:32PM +1200, Thomas Munro wrote:
> On Mon, Jul 8, 2024 at 2:49 AM Noah Misch <noah@leadboat.com> wrote:
> > what is the scope of the review you seek?
> 
> The patch "Refactor tidstore.c memory management." could definitely
> use some review.

That's reasonable.  radixtree already forbids mutations concurrent with
iteration, so there's no new concurrency hazard.  One alternative is
per_buffer_data big enough for MaxOffsetNumber, but that might thrash caches
measurably.  That patch is good to go apart from these trivialities:

> -    return &(iter->output);
> +    return &iter->output;

This cosmetic change is orthogonal to the patch's mission.

> -        for (wordnum = 0; wordnum < page->header.nwords; wordnum++)
> +        for (int wordnum = 0; wordnum < page->header.nwords; wordnum++)

Likewise.