Re: CI, macports, darwin version problems - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: CI, macports, darwin version problems
Date
Msg-id CA+hUKGLCBBL=nX5ABDmiWmaDNgELkNSDZH3Xy2jMpbVNQYWu8Q@mail.gmail.com
Whole thread Raw
In response to Re: CI, macports, darwin version problems  (Andres Freund <andres@anarazel.de>)
Responses Re: CI, macports, darwin version problems
List pgsql-hackers
On Tue, Jul 16, 2024 at 10:48 AM Andres Freund <andres@anarazel.de> wrote:
> WRT your patches:
> - I think we ought to switch to the -runner image, otherwise we'll just
>   continue to get that "upgraded" warning

Right, let's try it.

> - With a fingerprint_script specified, we need to add
>   reupload_on_changes: true
>   otherwise it'll not be updated.

Ahh, I see.

> - I think the fingerprint_script should use sw_vers, just as the script
>   does. I see no reason to differ?

Yeah might as well.  I started with Darwin versions because that is
what MacPorts complains about, but they move in lockstep.

> - We could just sw_vers -productVersion | sed 's/\..*//g' instead of the more
>   complicated version you used, I doubt that they're going to go away from
>   numerical major versions...

Yep.

I've attached a new version like that.  Let's see which runner machine
gets it and how it turns out...

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Confine vacuum skip logic to lazy_scan_skip
Next
From: Amit Kapila
Date:
Subject: Re: long-standing data loss bug in initial sync of logical replication