Re: GenBKI emits useless open;close for catalogs without rows - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: GenBKI emits useless open;close for catalogs without rows
Date
Msg-id 20230901174330.6jbe4izkew4nlt7k@alvherre.pgsql
Whole thread Raw
In response to GenBKI emits useless open;close for catalogs without rows  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
Responses Re: GenBKI emits useless open;close for catalogs without rows
Re: GenBKI emits useless open;close for catalogs without rows
List pgsql-hackers
On 2023-Sep-01, Matthias van de Meent wrote:

> A potential addition to the patch would to stop manually closing
> relations: initdb and check-world succeed without manual 'close'
> operations because the 'open' command auto-closes the previous open
> relation (in boot_openrel). Testing also suggests that the last opened
> relation apparently doesn't need closing - check-world succeeds
> without issues (incl. with TAP enabled). That is therefore implemented
> in attached patch 2 - it removes the 'close' syntax in its entirety.

Hmm, what happens with the last relation in the bootstrap process?  Is
closerel() called via some other path for that one?

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
Essentially, you're proposing Kevlar shoes as a solution for the problem
that you want to walk around carrying a loaded gun aimed at your foot.
(Tom Lane)



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Inefficiency in parallel pg_restore with many tables
Next
From: Matthias van de Meent
Date:
Subject: Re: GenBKI emits useless open;close for catalogs without rows