pg_stat_io not tracking smgrwriteback() is confusing - Mailing list pgsql-hackers

From Andres Freund
Subject pg_stat_io not tracking smgrwriteback() is confusing
Date
Msg-id 20230419172326.dhgyo4wrrhulovt6@awork3.anarazel.de
Whole thread Raw
Responses Re: pg_stat_io not tracking smgrwriteback() is confusing  ("Jonathan S. Katz" <jkatz@postgresql.org>)
Re: pg_stat_io not tracking smgrwriteback() is confusing  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
Hi,

I noticed that the numbers in pg_stat_io dont't quite add up to what I
expected in write heavy workloads. Particularly for checkpointer, the numbers
for "write" in log_checkpoints output are larger than what is visible in
pg_stat_io.

That partially is because log_checkpoints' "write" covers way too many things,
but there's an issue with pg_stat_io as well:

Checkpoints, and some other sources of writes, will often end up doing a lot
of smgrwriteback() calls - which pg_stat_io doesn't track. Nor do any
pre-existing forms of IO statistics.

It seems pretty clear that we should track writeback as well. I wonder if it's
worth doing so for 16? It'd give a more complete picture that way. The
counter-argument I see is that we didn't track the time for it in existing
stats either, and that nobody complained - but I suspect that's mostly because
nobody knew to look.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Direct I/O
Next
From: Peter Geoghegan
Date:
Subject: Re: Enhanced rmgr desc routines test !has_image, not has_data