Postgres Pro
Downloads
Home   >   mailing lists

Re: Generate pg_stat_get_* functions with Macros - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Generate pg_stat_get_* functions with Macros
Date
Msg-id 20221203005125.GA2561471@nathanxps13
Whole thread Raw
In response to Generate pg_stat_get_* functions with Macros  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
Responses Re: Generate pg_stat_get_* functions with Macros  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
Tree view 
Overall, this change looks straightforward, and it saves a couple hundred
lines.

On Tue, Nov 22, 2022 at 08:09:22AM +0100, Drouvot, Bertrand wrote:
> +/* pg_stat_get_numscans */
> +PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR(pg_stat_get_, numscans);
> +
> +/* pg_stat_get_tuples_returned */
> +PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR(pg_stat_get_, tuples_returned);
> +
> +/* pg_stat_get_tuples_fetched */
> +PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR(pg_stat_get_, tuples_fetched);

Can we hard-code the prefix in the macro?  It looks like all of these use
the same one.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: WAL Insertion Lock Improvements (was: Re: Avoid LWLockWaitForVar() for currently held WAL insertion lock in WaitXLogInsertionsToFinish())
Next
From: Michael Paquier
Date:
Subject: Re: Add LZ4 compression in pg_dump