Re: pgsql: Prevent instability in contrib/pageinspect's regression test. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
Date
Msg-id 20221121172206.h6kywxrzqcmhoqom@awork3.anarazel.de
Whole thread Raw
In response to pgsql: Prevent instability in contrib/pageinspect's regression test.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
List pgsql-committers
Hi,

On 2022-11-21 15:51:05 +0000, Tom Lane wrote:
> Prevent instability in contrib/pageinspect's regression test.
> 
> pageinspect has occasionally failed on slow buildfarm members,
> with symptoms indicating that the expected effects of VACUUM
> FREEZE didn't happen.  This is presumably because a background
> transaction such as auto-analyze was holding back global xmin.
> 
> We can work around that by using a temp table in the test.
> Since commit a7212be8b, that will use an up-to-date cutoff xmin
> regardless of other processes.  And pageinspect itself shouldn't
> really care whether the table is temp.
> 
> Back-patch to v14.  There would be no point in older branches
> without back-patching a7212be8b, which seems like more trouble
> than the problem is worth.

Looks like a chunk of the buildfarm doesn't like this - presumably because
they use force_parallel_mode = regress. Seems ok to just force that to off in
this test?

Greetings,

Andres Freund



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Provide options for postmaster to kill child processes with SIGA
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Prevent instability in contrib/pageinspect's regression test.