pgsql: Prevent instability in contrib/pageinspect's regression test. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Prevent instability in contrib/pageinspect's regression test.
Date
Msg-id E1ox94a-000EHu-VH@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
List pgsql-committers
Prevent instability in contrib/pageinspect's regression test.

pageinspect has occasionally failed on slow buildfarm members,
with symptoms indicating that the expected effects of VACUUM
FREEZE didn't happen.  This is presumably because a background
transaction such as auto-analyze was holding back global xmin.

We can work around that by using a temp table in the test.
Since commit a7212be8b, that will use an up-to-date cutoff xmin
regardless of other processes.  And pageinspect itself shouldn't
really care whether the table is temp.

Back-patch to v14.  There would be no point in older branches
without back-patching a7212be8b, which seems like more trouble
than the problem is worth.

Discussion: https://postgr.es/m/2892135.1668976646@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e2933a6e11791191050cd925d52d34e785eece77

Modified Files
--------------
contrib/pageinspect/expected/page.out | 3 ++-
contrib/pageinspect/sql/page.sql      | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Replace SQLValueFunction by COERCE_SQL_SYNTAX
Next
From: Tom Lane
Date:
Subject: pgsql: Provide options for postmaster to kill child processes with SIGA