Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows. - Mailing list pgsql-committers

On Tue, Oct 25, 2022 at 04:21:02PM -0500, Justin Pryzby wrote:
> > Restore that behavior with an explicit check, to see if it fixes the
> > occasional 'directory not empty' failures seen in the pg_upgrade tests
> > on CI.  Further improvements are possible with proposed upgrades to
> > modern Windows APIs that would replace this convoluted code.
> > 
> > Reported-by: Justin Pryzby <pryzby@telsasoft.com>
> > Reviewed-by: Michael Paquier <michael@paquier.xyz>
> > Discussion: https://postgr.es/m/20220920013122.GA31833%40telsasoft.com
> > Discussion: https://postgr.es/m/CA%2BhUKG%2BajSQ_8eu2AogTncOnZ5me2D-Cn66iN_-wZnRjLN%2Bicg%40mail.gmail.com
> ...
> > Details
> > -------
> > https://git.postgresql.org/pg/commitdiff/e109e43921d21d069c03f18d7c9d8f4e5cb6a0c3
> 
> If I'm not wrong, this didn't fix the issue you said it fixed.

s/said/hoped/sorry