Re: Crash after a call to pg_backup_start() - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Crash after a call to pg_backup_start()
Date
Msg-id 20221024093919.miogwtncx6au4zqd@alvherre.pgsql
Whole thread Raw
In response to Re: Crash after a call to pg_backup_start()  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 2022-Oct-24, Michael Paquier wrote:

> On the contrary, it seems to me that putting the assertion within the
> if() block makes the assertion weaker, because we would never check
> for an incorrect state after do_pg_abort_backup() is registered (aka
> any pg_backup_start() call) when not entering in this if() block.

Reading it again, I agree with your conclusion, so I'll push as you
proposed with some extra tests, after they complete running.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"La verdad no siempre es bonita, pero el hambre de ella sí"



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Question about savepoint level?
Next
From: Peter Eisentraut
Date:
Subject: pg_dump: Refactor code that constructs ALTER ... OWNER TO commands