Re: New "single-call SRF" APIs are very confusingly named - Mailing list pgsql-hackers

From Andres Freund
Subject Re: New "single-call SRF" APIs are very confusingly named
Date
Msg-id 20221016220443.vjd7a5dj34gj7vck@awork3.anarazel.de
Whole thread Raw
In response to Re: New "single-call SRF" APIs are very confusingly named  (Melanie Plageman <melanieplageman@gmail.com>)
Responses Re: New "single-call SRF" APIs are very confusingly named
List pgsql-hackers
Hi,

On 2022-10-16 13:22:41 -0700, Melanie Plageman wrote:
> On Fri, Oct 14, 2022 at 7:41 PM Michael Paquier <michael@paquier.xyz> wrote:
> - * SetSingleFuncCall
> + * Compatibility function for v15.
> + */
> +void
> +SetSingleFuncCall(FunctionCallInfo fcinfo, bits32 flags)
> +{
> + InitMaterializedSRF(fcinfo, flags);
> +}
> +
> 
>  Any reason not to use a macro?

Yes - it'd introduce an ABI break, i.e. an already compiled extension
referencing SetSingleFuncCall() wouldn't fail to load into an upgraded sever,
due to the reference to the SetSingleFuncCall, which wouldn't exist anymore.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: macos ventura SDK spews warnings
Next
From: Andres Freund
Date:
Subject: Re: New "single-call SRF" APIs are very confusingly named