Re: Typo in xact.c - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Typo in xact.c
Date
Msg-id 20220916.121135.398256374890151741.horikyota.ntt@gmail.com
Whole thread Raw
In response to Typo in xact.c  (Japin Li <japinli@hotmail.com>)
Responses Re: Typo in xact.c
Re: Typo in xact.c
List pgsql-hackers
At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li <japinli@hotmail.com> wrote in 
> 
> Hi hacker,
> 
> Recently, I find there might be a typo in xact.c comments.  The comments
> say "PG_PROC", however, it actually means "PGPROC" structure.  Since we
> have pg_proc catalog, and use PG_PROC to reference the catalog [1], so,
> we should use PGPROC to reference the structure.  Any thoughts?
> 
> [1] src/include/nodes/primnodes.h

The patch seems to me covering all occurances of PG_PROC as PGPROC.

I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is
quite confusing, too..

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: Inconsistencies in error messages
Next
From: Justin Pryzby
Date:
Subject: Re: Background writer and checkpointer in crash recovery