Re: Avoid overhead with fprintf related functions - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Avoid overhead with fprintf related functions
Date
Msg-id 20220909221142.GC2258997@nathanxps13
Whole thread Raw
In response to Re: Avoid overhead with fprintf related functions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Sep 09, 2022 at 05:53:54PM -0400, Tom Lane wrote:
> Ranier Vilela <ranier.vf@gmail.com> writes:
>> Em sex., 9 de set. de 2022 às 13:20, Nathan Bossart <
>> nathandbossart@gmail.com> escreveu:
>>> I agree with David [0].  But if you can demonstrate a performance gain,
>>> perhaps it's worth considering a subset of these changes in hot paths.
> 
>> head:
>> Time: 418,210 ms
>> Time: 419,588 ms
>> Time: 424,713 ms
> 
>> fprintf patch:
>> Time: 416,919 ms
>> Time: 416,246 ms
>> Time: 416,237 ms
> 
> That is most certainly not enough gain to justify a large amount
> of code churn.  In fact, given that this is probably pretty
> platform-dependent and you've checked only one platform, I don't
> think I'd call this a sufficient case for even a one-line change.

Agreed.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Next
From: Ibrar Ahmed
Date:
Subject: [Commitfest 2022-09] First week is over