Hi,
On 2022-09-04 18:04:13 +0700, John Naylor wrote:
> On Sun, Sep 4, 2022 at 4:36 PM John Naylor <john.naylor@enterprisedb.com> wrote:
> >
> > For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe
> > something like the following is needed:
> >
> > --- a/src/tools/msvc/Mkvcbuild.pm
> > +++ b/src/tools/msvc/Mkvcbuild.pm
> > @@ -362,6 +362,7 @@ sub mkvcbuild
> > $isolation_tester->AddFile('src/test/isolation/specparse.y');
> > $isolation_tester->AddFile('src/test/isolation/specscanner.l');
> > $isolation_tester->AddFile('src/test/isolation/specparse.c');
> > + $isolation_tester->AddFile('src/test/isolation/specscanner.c');
> > $isolation_tester->AddIncludeDir('src/test/isolation');
>
> This gets CI green (tip o' the hat to Thomas Munro for off-list advice
> on getting that working), so pushed.
It doesn't seem to have gotten all of CI green, cpluspluscheck fails:
https://cirrus-ci.com/task/6561938334285824
I think this just needs a copy the logic you added to headerscheck also to
cpluspluscheck (and yes, we should merge these files one of these days).
Greetings,
Andres Freund
