Re: [PATCH] Log details for client certificate failures - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Log details for client certificate failures
Date
Msg-id 20220715234519.7o4mlpxapmqmv6p7@awork3.anarazel.de
Whole thread Raw
In response to Re: [PATCH] Log details for client certificate failures  (Jacob Champion <jchampion@timescale.com>)
Responses Re: [PATCH] Log details for client certificate failures
List pgsql-hackers
Hi,

On 2022-07-15 14:51:38 -0700, Jacob Champion wrote:
> > We already have pg_clean_ascii() and use it for application_name, fwiw.
> 
> That seems much worse than escaping for this particular patch; if your
> cert's Common Name is in (non-ASCII) UTF-8 then all you'll see is
> "CN=?????????" in the log lines that were supposed to be helping you
> root-cause. Escaping would be much more helpful in this case.

I'm doubtful that's all that common. But either way, I suggest a separate
patch to deal with that...

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: [Commitfest 2022-07] Begins Now
Next
From: Andres Freund
Date:
Subject: Re: [Commitfest 2022-07] Begins Now