Re: [PATCH] Log details for client certificate failures - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: [PATCH] Log details for client certificate failures
Date
Msg-id CAAWbhmiH2dPpRUnpS6pe9Fge--gj_az4ra2AJO1JvTKeiFuAug@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Log details for client certificate failures  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Log details for client certificate failures
List pgsql-hackers
On Fri, Jul 15, 2022 at 4:45 PM Andres Freund <andres@anarazel.de> wrote:
> On 2022-07-15 14:51:38 -0700, Jacob Champion wrote:
> > That seems much worse than escaping for this particular patch; if your
> > cert's Common Name is in (non-ASCII) UTF-8 then all you'll see is
> > "CN=?????????" in the log lines that were supposed to be helping you
> > root-cause. Escaping would be much more helpful in this case.
>
> I'm doubtful that's all that common.

Probably not, but the more systems that support it without weird
usability bugs, the more common it will hopefully become.

> But either way, I suggest a separate patch to deal with that...

Proposed fix attached, which uses \x-escaping for bytes outside of
printable ASCII.

Thanks,
--Jacob

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: NAMEDATALEN increase because of non-latin languages
Next
From: Andres Freund
Date:
Subject: Re: [PATCH] Log details for client certificate failures