At Tue, 15 Mar 2022 18:48:34 +0300, Maxim Orlov <orlovmg@gmail.com> wrote in
> Hi Kyotaro!
>
> 0001:
> >
> > The XID_FMT has quite bad impact on the translatability of error
> > messages. 3286065651 has removed INT64_FORMAT from translatable
> > texts for the reason. This re-introduces that in several places.
> > 0001 itself does not harm but 0005 replaces XID_FMT with
> > INT64_FORMAT. Other patches have the same issue, too.
> >
> I do understand your concern and I wonder how I can do this better? My
> first intention was to replace XID_FMT with %llu and INT64_FORMAT with
> %lld. This should solve the translatability issue, but I'm not sure about
> portability of this. Should this work on Windows, etc? Can you advise me on
> the best solution?
Doesn't doing "errmsg("blah blah %lld ..", (long long) xid)" work?
> We've fixed all the other things mentioned. Thanks!
>
> Also added two fixes:
> - CF bot was unhappy with pg_upgrade test in v17 because I forgot to add a
> fix for computation of relminmxid during vacuum on a fresh database.
> - Replace frozen or invalid x_min with FrozenTransactionId or
> InvalidTransactionId respectively during tuple conversion to 64xid.
>
> Reviews are welcome as always! Thanks!
My pleasure.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
