Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai - Mailing list pgsql-committers

Hi,

On 2022-01-30 17:35:48 -0800, Andres Freund wrote:
> I see this broke on everywhere but master. Looking.

Ugh. It's that we didn't backport pport.h.

commit 05798c9f7f08908bdd06c82d934da67535b72005
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   2021-10-07 13:59:43 -0400

    plperl: update ppport.h to Perl 5.34.0.

    Also apply the changes suggested by running
        perl ppport.h --compat-version=5.8.0

    And remove some no-longer-required NEED_foo declarations.

    Dagfinn Ilmari Mannsåker

    Discussion: https://postgr.es/m/87y278s6iq.fsf@wibble.ilmari.org


I didn't see that locally (linux) on the backbranches earlier
because I had the
#if defined(WIN32) && PERL_VERSION_LT(5, 28, 0)
split over two ifdefs. And only merged it in a last bit of cleanup :(

Unless somebody comes up with a better idea quickly I'm going use a plain
PERL_VERSION check in the backbranches. Might also be a good idea to backpatch
the above commit, but that requires more discussion than I want to leave the
buildfarm red for.

Greetings,

Andres Freund