Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Date
Msg-id 535668.1643594467@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> On 2022-01-30 17:35:48 -0800, Andres Freund wrote:
>> I see this broke on everywhere but master. Looking.

> Ugh. It's that we didn't backport pport.h.

Ooops.

> Unless somebody comes up with a better idea quickly I'm going use a plain
> PERL_VERSION check in the backbranches. Might also be a good idea to backpatch
> the above commit, but that requires more discussion than I want to leave the
> buildfarm red for.

I think we oughta backport.  We didn't do so at the time because
we thought it was mostly cosmetic/future-proofing, but evidently
the future is now.

I can look into that tomorrow or so.

            regards, tom lane



pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Next
From: Andres Freund
Date:
Subject: pgsql: plperl: Fix breakage of c89f409749c in back branches.