Re: Partitioned index can be not dumped - Mailing list pgsql-hackers

On 2021-Jun-30, Zhihong Yu wrote:

> Hi,
> In that case, I wonder whether nindexes can be negated following the call
> to vac_open_indexes().
> 
>         vac_open_indexes(onerel, AccessShareLock, &nindexes, &Irel);
> +       nindexes = -nindexes;
> 
> That way, hasindex can be dropped.
> vac_update_relstats() call would become:
> 
>         vac_update_relstats(onerel, -1, totalrows,
> -                           0, false, InvalidTransactionId,
> +                           0, nindexes != 0, InvalidTransactionId,

Perhaps this works, but I don't think it's a readability improvement.

> My thinking is that without hasindex, the code is easier to maintain.

You have one less variable but one additional concept (negative
nindexes).  It doesn't seem easier to me, TBH, rather the opposite.

-- 
Álvaro Herrera                            39°49'30"S 73°17'W
                               https://www.EnterpriseDB.com/