Re: Enhanced error message to include hint messages for redundant options error - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Enhanced error message to include hint messages for redundant options error
Date
Msg-id 20210510211714.GA32638@alvherre.pgsql
Whole thread Raw
In response to Re: Enhanced error message to include hint messages for redundant options error  (vignesh C <vignesh21@gmail.com>)
Responses Re: Enhanced error message to include hint messages for redundant options error
Re: Enhanced error message to include hint messages for redundant options error
List pgsql-hackers
On 2021-May-10, vignesh C wrote:

> That sounds fine to me, Attached v6 patch which has the changes for the same.

What about defining a function (maybe a static inline function in
defrem.h) that is marked noreturn and receives the DefElem and
optionally pstate, and throws the error?  I think that would avoid the
patch's need to have half a dozen copies of the "duplicate_error:" label
and ereport stanza.

-- 
Álvaro Herrera                            39°49'30"S 73°17'W



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Reducing opr_sanity test's runtime under CLOBBER_CACHE_ALWAYS
Next
From: Thomas Munro
Date:
Subject: Re: Reducing opr_sanity test's runtime under CLOBBER_CACHE_ALWAYS