Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ... - Mailing list pgsql-hackers

From David Fetter
Subject Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...
Date
Msg-id 20210428025308.GC17834@fetter.org
Whole thread Raw
In response to Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
On Tue, Apr 27, 2021 at 12:33:25PM +0300, Aleksander Alekseev wrote:
> Hi David,
> 
> > I noticed that $subject completes with already valid constraints,
> > please find attached a patch that fixes it. I noticed that there are
> > other places constraints can be validated, but didn't check whether
> > similar bugs exist there yet.
> 
> There was a typo in the patch ("... and and not convalidated"). I've fixed
> it. Otherwise the patch passes all the tests and works as expected:
> 
> eax=# create table foo (x int);
> CREATE TABLE
> eax=# alter table foo add constraint bar check (x < 3) not valid;
> ALTER TABLE
> eax=# alter table foo add constraint baz check (x <> 5) not valid;
> ALTER TABLE
> eax=# alter table foo validate constraint ba
> bar baz
> eax=# alter table foo validate constraint bar;
> ALTER TABLE

Sorry about that typo, and thanks for poking at this!

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate



pgsql-hackers by date:

Previous
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: Parallel INSERT SELECT take 2
Next
From: Greg Nancarrow
Date:
Subject: Error in libpq docs for target_session_attrs, prefer-standby mode