Wrong HINT during database recovery when occur a minimal wal. - Mailing list pgsql-hackers

From
Subject Wrong HINT during database recovery when occur a minimal wal.
Date
Msg-id 20210115071919.215B5464046E@webmail.sinamail.sina.com.cn
Whole thread Raw
List pgsql-hackers
Hello hackers,

When I do PITR in a strange step, I get this FATAL:

2021-01-15 15:02:52.364 CST [14958] FATAL:  hot standby is not possible because wal_level was not set to "replica" or higher on the primary server
2021-01-15 15:02:52.364 CST [14958] HINT:  Either set wal_level to "replica" on the primary, or turn off hot_standby here.

The strange step is that I change wal_level to minimal after basebackup.

My question is that what's the mean of  [set wal_level to "replica" on the primary] in
HINT describe, I can't think over a case to solve this FATAL by set wal_level, I can
solve it by turn off hot_standby only.

Do you think we can do this code change?
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -6300,7 +6300,7 @@ CheckRequiredParameterValues(void)
  if (ControlFile->wal_level < WAL_LEVEL_REPLICA)
  ereport(ERROR,
  (errmsg("hot standby is not possible because wal_level was not set to \"replica\" or higher on the primary server"),
- errhint("Either set wal_level to \"replica\" on the primary, or turn off hot_standby here.")));
+ errhint("You should turn off hot_standby here.")));


---
Regards,
Highgo Software (Canada/China/Pakistan)
URL : www.highgo.ca
EMAIL: mailto:movead(dot)li(at)highgo(dot)ca

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [patch] [doc] Further note required activity aspect of automatic checkpoint and archving
Next
From: Peter Eisentraut
Date:
Subject: Re: WIP: document the hook system