Re: pg_service.conf file with iso-8859-1 parameters - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_service.conf file with iso-8859-1 parameters
Date
Msg-id 20200918233201.GE30016@momjian.us
Whole thread Raw
In response to pg_service.conf file with iso-8859-1 parameters  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Fri, Sep 11, 2020 at 02:39:51PM +0200, Magnus Hagander wrote:
> Right now, pg_service.conf returns "syntax error" if it encounters a parameter
> it doesn't know about.
> 
> This seems user-unfriendly, both in the error message (because it really isn't
> a syntax error) and in the behaviour itself (because it doesn't work when
> sometimes it should).
> 
> For example, if I have a service file with gssencmode=disable set, that service
> file cannot be used by a psql client linked against libpq from version 10. Even
> if the behavior would be identical (since v10 doesn't have gssencmode).
> 
> Is there a particular reason we (1) refuse unknown parameters in the file, and
> (2) call it a "syntax error"?
> 
> The documentation just says it's "INI format" file -- though in my experience
> most other INI file parsers just ignore extra parameters included..

My guess is that because the file can contain passwords, we want to
report as little as possible on error.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee




pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Proposal of new PostgreSQL Extension - PGSpiderExt
Next
From: Thomas Munro
Date:
Subject: Re: Division in dynahash.c due to HASH_FFACTOR