Greetings,
* Andres Freund (andres@anarazel.de) wrote:
> On 2020-03-27 14:34:19 -0400, Robert Haas wrote:
> > I think #2 is an interesting idea and could possibly reduce the danger
> > of user confusion on this point considerably - because, let's face it,
> > not everyone is going to read the documentation. However, I'm having a
> > hard time figuring out exactly what we'd print. Right now on success,
> > unless you specify -q, you get:
> >
> > [rhaas ~]$ pg_validatebackup ~/pgslave
> > backup successfully verified
> >
> > But it feels strange and possibly confusing to me to print something like:
> >
> > [rhaas ~]$ pg_validatebackup ~/pgslave
> > backup successfully verified (except for pg_wal)
>
> You could print something like:
> WAL necessary to restore this base backup can be validated with:
>
> pg_waldump -p ~/pgslave -t tl -s backup_start_location -e backup_end_loc > /dev/null && echo true
>
> Obviously that specific invocation sucks, but it'd not be hard to add an
> option to waldump to not output anything.
Interesting idea to use pg_waldump.
I had suggested up-thread, and I'm still fine with, having
pg_validatebackup scan the WAL and check the internal checksums. I'd
prefer an option that uses hashes to check when the user has asked for
hashes with SHA256 or something, but at least scanning the WAL and
making sure it validates its internal checksum (and is actually all
there, which is pretty darn critical) would be enough to say that we're
pretty sure the backup is valid.
Thanks,
Stephen
